enhancement: Add pretty parameter for encode_json
#370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `pretty` parameter for `encode_json` function to produce pretty-printed JSON string.
pront
approved these changes
Aug 4, 2023
| @@ -1,8 +1,15 @@ | |||
| use crate::compiler::prelude::*; | |||
|
|
|||
| fn encode_json(value: Value) -> Resolved { | |||
| fn encode_json(value: Value, pretty: bool) -> Resolved { | |||
There was a problem hiding this comment.
It is a good practice to avoid bool parameters. There are many ways to refactor:
- an options
struct enuminstead ofbool- extract implementation details and split
encode_jsoninto two functions
pront
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
prettyparameter forencode_jsonfunction to produce pretty-printed JSON string.closes #358