Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stdlib): support microseconds in from_unix_timestamp #492

Merged
merged 1 commit into from
Oct 5, 2023
Merged

feat(stdlib): support microseconds in from_unix_timestamp #492

merged 1 commit into from
Oct 5, 2023

Conversation

emikitas
Copy link
Contributor

@emikitas emikitas commented Oct 3, 2023

resolves #491

@pront pront self-requested a review October 3, 2023 14:44
pront
pront approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution @emikitas. This looks good.

src/stdlib/from_unix_timestamp.rs
@@ -198,6 +205,12 @@ mod tests {
tdef: TypeDef::timestamp().fallible(),
}

integer_microseconds {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add an example (line 74).

@emikitas emikitas force-pushed the support_microseconds_in_from_unix_timestamp branch from 8235fb3 to f300a9a Compare October 4, 2023 05:46
@emikitas
Copy link
Contributor Author

emikitas commented Oct 4, 2023

I noticed I botched one of my commit messages, so I decided to squash the commit adding the example into it and amend the commit message.

@pront pront enabled auto-merge October 4, 2023 14:16
auto-merge was automatically disabled October 4, 2023 17:32

Head branch was pushed to by a user without write access

@emikitas emikitas force-pushed the support_microseconds_in_from_unix_timestamp branch from f300a9a to 3c6c612 Compare October 4, 2023 17:32
@pront pront changed the title Support microseconds in from unix timestamp feat: Support microseconds in from unix timestamp Oct 4, 2023
@pront
Copy link
Contributor

pront commented Oct 4, 2023 •
edited
Loading

I noticed I botched one of my commit messages, so I decided to squash the commit adding the example into it and amend the commit message.

Hi @emikitas, feel free to push as many commits as you need. We squash all commits before merging. However, make sure to follow https://www.conventionalcommits.org/en/v1.0.0/ for the final commit.

@emikitas
feature(stdlib): support new Unit for UNIX timestamps- microseconds
eed919b 
* Add new Unit for UNIX timestamps - microseconds.
* Support to & from UNIX timestamps in microseconds.
* Minor code cleanups
@emikitas emikitas force-pushed the support_microseconds_in_from_unix_timestamp branch from 3c6c612 to eed919b Compare October 5, 2023 05:44
@pront pront changed the title feat: Support microseconds in from unix timestamp feat(stdlib): support microseconds in from_unix_timestamp Oct 5, 2023
@pront pront enabled auto-merge October 5, 2023 13:37
@pront pront added this pull request to the merge queue Oct 5, 2023
Merged via the queue into vectordotdev:main with commit 4dc9d14 Oct 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pront pront pront approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support microseconds in from_unix_timestamp
2 participants
@emikitas @pront