fix(stdlib): ensure punycode functions keep all input parts #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion is off I have implemented validation skip in vectordotdev#709, which ignores errors returned by `idna` crate when encoding and decoding punycode. One of the errors that it could return would result in output with missing sections (as was demonstrated in tests - e.g. `multiple_errors_ignore`). Since it is fairly trivial to split domain into parts (`idna` crate does it by doing split on `.`), we can split the domain ourselves in cases when we don't want validation and then try to encode ones that need encoding and leave them as they were if encoding (or decoding) fails. Related: vectordotdev#709
pront
approved these changes
Feb 22, 2024
|
I haven't added a changelog since it affects changes that were already covered by a changelog entry that wasn't yet released. Is that alright or should I add one? |
👍 that seems right since the other change hasn't been released yet. |
jszwedko
added
the
no-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented validation skip in #709, which ignores errors returned by
idnacrate when encoding and decoding punycode. One of the errors that it could return would result in output with missing sections (as was demonstrated in tests - e.g.multiple_errors_ignore). Since it is fairly trivial to split domain into parts (idnacrate does it by doing split on.), we can split the domain ourselves in cases when we don't want validation and then try to encode ones that need encoding and leave them as they were if encoding (or decoding) fails.Related: #709