feat(stdlib): add optional psl argument to parse_etld
#851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an optional argument `psl` to `parse_etld`function, which should be a file path to a custom PSL list (default one can be found on https://publicsuffix.org/list/public_suffix_list.dat). If none is provided, the default is used. Related: vectordotdev#669
pront
approved these changes
May 21, 2024
lib/tests/tests/functions/parse_etld/custom_psl_file_does_not_exist.vrl
Outdated
Show resolved
Hide resolved
lib/tests/tests/functions/parse_etld/custom_psl_file_wrong_format.vrl
Outdated
Show resolved
Hide resolved
github-merge-queue bot
pushed a commit
to vectordotdev/vector
that referenced
this pull request
Jun 13, 2024
* docs(vrl): add docs for `psl` argument for `parse_etld` Related: vectordotdev/vrl#851 * Add comma after "By default" in docs Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Allow psl in spellchecker * Fix parse_etld_psl example Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> * Fix example Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> --------- Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> Co-authored-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
github-merge-queue bot
pushed a commit
to vectordotdev/vector
that referenced
this pull request
Jun 13, 2024
* docs(vrl): add docs for `psl` argument for `parse_etld` Related: vectordotdev/vrl#851 * Add comma after "By default" in docs Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Allow psl in spellchecker * Fix parse_etld_psl example Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> * Fix example Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> --------- Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> Co-authored-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
github-merge-queue bot
pushed a commit
to vectordotdev/vector
that referenced
this pull request
Jun 13, 2024
* docs(vrl): add docs for `psl` argument for `parse_etld` Related: vectordotdev/vrl#851 * Add comma after "By default" in docs Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Allow psl in spellchecker * Fix parse_etld_psl example Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> * Fix example Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> --------- Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> Co-authored-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
github-merge-queue bot
pushed a commit
to vectordotdev/vector
that referenced
this pull request
Jun 14, 2024
* docs(vrl): add docs for `psl` argument for `parse_etld` Related: vectordotdev/vrl#851 * Add comma after "By default" in docs Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> * Allow psl in spellchecker * Fix parse_etld_psl example Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> * Fix example Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> --------- Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> Co-authored-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional argument
psltoparse_etldfunction, which should be a file path to a custom PSL list (default one can be found on https://publicsuffix.org/list/public_suffix_list.dat). If none is provided, the default is used.Related: #669