Adds front_matter.cr #290
Merged
Adds front_matter.cr #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veelenga
requested changes
May 29, 2018
There was a problem hiding this comment.
Could you please apply the official guidelines Writing Shards to your shard?
|
Which particular points are your referring to? |
|
Well, formatting, travis build, published docs, first release are good signs of well-maintained project. We usually ask all projects to follow those guidelines. Thanks for understanding. |
|
I am happy to do everything with the exception of the standard formatting. I won't use spaces over tabs on stuff I don't have to. |
|
A description - with examples - of what a front matter is would help the readme loads. |
|
@veelenga - Please have a look at the changes, they should meet your expectations now. :) |
|
@RX14 - I also improved the documentation. If you have any suggestions let me know. |
veelenga
approved these changes
May 30, 2018
hugoabonizio
approved these changes
May 30, 2018
veelenga
pushed a commit
to chris-huxtable/awesome-crystal
that referenced
this pull request
Jun 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
front_matter.cr