Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keimeno TUI engine #495

Merged
merged 2 commits into from
Apr 5, 2020
Merged

Add Keimeno TUI engine #495

merged 2 commits into from
Apr 5, 2020

Conversation

robacarp
Copy link
Contributor

@robacarp robacarp commented Apr 4, 2020

I have no idea if the project is mature enough to warrant being on here. I use this library for a handful of my own utilities and it's been great. I don't have tests written for it. I just think it'd be good to get some other eyes on it.

I also don't know if it should be in CLI Builders or CLI Utilities. The list of builders is essentially just option parsers, but utilities are ... applications which run in the console.

Link

Checklist

  • - Shard is at least 30 days old.
  • - Shard has CI implemented.
  • - Shard has daily/weekly periodic builds (ideally with Crystal latest and nightly).

I have no idea if the project is mature enough to warrant being on here. I use this library for a handful of my own utilities and it's been great. I don't have tests written for it. I just think it'd be good to get some other eyes on it.

I also don't know if it should be in CLI Builders or CLI Utilities. The list of builders is _essentially_ just option parsers, but utilities are ... applications which run in the console.
Copy link
Collaborator

@hugoabonizio hugoabonizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding it under CLI Builders make sense. The FZF like demo link on readme is broken.

Copy link
Owner

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to extend the test suite.

@Blacksmoke16
Copy link
Collaborator

@robacarp Will need the order updated for CI to pass then can :shipit:

@Blacksmoke16 Blacksmoke16 merged commit ba4edb1 into veelenga:master Apr 5, 2020
@robacarp robacarp deleted the patch-1 branch April 6, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants