Quick fix in setup.py #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks 👍 |
This was referenced Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys, there is an issue preventing the installation of CommPy 0.7.0 via PIP in Windows. When attempting to do
pip install scikit-commpyon Windows, version 0.6.0 is installed instead, due to a bug in setup.py in version 0.7.0. I don't know if the same issue appears in other OS. Looking at the error logs and similar issues reported on StackOverflow, I found a quick fix.In setup.py, change:
to
That should fix the pip installation on Windows. I tested it and this fix allowed me to install version 0.7.0 on my Windows PC.