Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New in channel codes README #40

Merged
merged 6 commits into from
Aug 15, 2019
Merged

New in channel codes README #40

merged 6 commits into from
Aug 15, 2019

Conversation

kirlf
Copy link
Contributor

@kirlf kirlf commented Aug 6, 2019

The simulation of the convolutional codes was added.

@BastienTr
Copy link
Collaborator

BastienTr commented Aug 6, 2019

I recommend merging this PR as an updated example is a very good idea. I make a few comments as a code review.

The Travis error seems not related to this PR as it only modify a Readme.md. Besides the Travis error deals with the conda environment setup: the line conda create -q -n test-environment python=$TRAVIS_PYTHON_VERSION atlas numpy scipy matplotlib nose used to work 2 months ago and now returns a PackagesNotFoundError for atlas. An issue is open at #43.

Copy link
Collaborator

@BastienTr BastienTr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend merging this PR after this small changes. Thanks for this @kirlf 👍

commpy/channelcoding/README.md Show resolved Hide resolved
commpy/channelcoding/README.md Outdated Show resolved Hide resolved
commpy/channelcoding/README.md Outdated Show resolved Hide resolved
@kirlf
Copy link
Contributor Author

kirlf commented Aug 14, 2019

Dear, @veeresht and @BastienTr !
I have an idea: maybe it will be more opportunely to move this README to the Wiki of the project?

@BastienTr
Copy link
Collaborator

At the moment there is no wiki and we didn't plan to make one. I think we should leave the readme as is and start a wiki later if we can offer similar readme for the other modules.

@veeresht
Copy link
Owner

At the moment there is no wiki and we didn't plan to make one. I think we should leave the readme as is and start a wiki later if we can offer similar readme for the other modules.

I agree with @BastienTr. Maybe Wiki can be organized and created once there is enough content.

@veeresht veeresht merged commit 91c313e into veeresht:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants