-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug fix] Bad typing in links.py introduced in bcc36ddc #88
Conversation
Before going forward with this merge I have a couple of issues. First it points an error that currently no test exists to catch it, maybe a test case should be also added. Second, if this is merged, the bitwise_xor will fail (travis already said the same). This could be solve by rolling back commit a9d3aa7, but has a performance hit. |
I have a look this weekend. I agree that we may need a new testcase. We have to fix this anyway. Performance is cool but if the result is false for sort detectors, it's not acceptable. We may find a way to have both. |
Completely agree! Also, I'm not well verse in the the topic of MIMO decoding and soft detectors, sorry for this bug, completely flew bellow my radar. If you could drop a reference as a pointer would greatly appreciate! |
I push the modified code as soon as all tests pass on my laptop.
Done. I refactor
You were right to introduce
On MIMO detection, I recommend this really good state of the art that includes soft detection: Fifty Years of MIMO Detection. |
Does someone know what is the default working directory when Travis executes the tests? |
@eSoares, do you commit that this is OK for you? |
Looks good 👍 Also, thanks for the reference! :-) |
Commit bcc36dd introduced a typing error in
link_performance
. Typingreceived_msg
asint
prevent soft detectors to work properly as LLRs are converted to integers. I can provide a minimal example for this but any test with soft detectors shows the error.@eSoares: Since you hadded this, could you confirm that this is not need required so that I merge this PR before v0.6 release.