Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README code example for channelcoding #92

Merged
merged 3 commits into from Nov 10, 2020

Conversation

londumas
Copy link

Fix both issues : #90 and #89.

This PR fixes different issues with the example code in channelcoding/README.md :

  • memory should be a numpy 1D array
  • np.array([[0o171, 0o133]]) generator matrix was producing errors, I replaced by the one in the docstring examples np.array([[5, 7]])
  • decoded messages and demodulated messages can be padded due to the modulation type.

@coveralls
Copy link

coveralls commented Nov 10, 2020

Coverage Status

Coverage remained the same at 82.353% when pulling 1fc1334 on londumas:fix-codding-deconding-readme into 65bfc19 on veeresht:master.

@BastienTr BastienTr merged commit 97003c0 into veeresht:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants