refactor: improve importability #44
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moved the scripts package under the hivtrace namespace - appended `.py` to the script names where necessary - added a __main__.py file, defining the entrypoint functions - removed the scripts in setup.py and make them available as entrypoints - wrapped the code in hivnetworkannotate.py in functions - changed to relative imports, because the ad-hoc layout otherwise confuses pycharm - also did some very slight reformatting (add some indentation) in setup.py
TODO: some open questions - why the random.seed(), and where does it need to happen? it's happening twice now - once before parsing arguments - and once before doing the annotations - run_settings is global, and mutated by functions via side effects - this change does not immediately seem to break things - but there are no tests, so someone knowledgeable might want to check
FynnFreyer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #42, and includes two commits:
For this one there are a few open questions
If only parts of this would be wanted, I can split these changes up into multiple commits, and you can cherry pick/whatever.
This doesn't include the commits in #41, but should be compatible without merge conflicts.