-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: update to Vega-Lite 5 #2516
Conversation
Sample417
The way the schema is written for TopLevelRepeatSpec gives the current code trouble. We patch it in an ad hoc way, and should later find a more sustainable method.
Instead of patching the downloaded schema, we change the definition of RepeatChart. Currently the test_chart_from_dict test from altair/vegalite/v4/tests/test_api.py is failing on base.repeat(["c", "d"]).
Same as the previous commit but in the correct file, not the auto-generated file.
I think the proper method is to fetch master first, rebase your branch and then do a pull request, but I think I would do what you wrote. |
(Draft version only!)
Surprisingly the biggest obstacle so far hasn't been
params
but a change tolayer
. I think in the newest Vega-Lite schema, charts in a layer are not allowed to specify height or width, which seems to break many Altair examples. Here is a minimal example that doesn't work:I don't see a good way to deal with that. Do you have a suggestion?
I've read the list of "breaking changes" for the Vega-Lite 5.0.0 release and don't see anything that seems related to this, so it does make me wonder if maybe I misunderstand the cause of the problem.
Other things:
Error loading script: Script error for "vega-util", needed by: vega-lite http://requirejs.org/docs/errors.html#scripterror
It does work in Jupyter Lab.selection
fits with the newparameter
. It might be best to redo this code later now that I see more of the big picture.