Skip to content

Commit

Permalink
Use and test linter for ts
Browse files Browse the repository at this point in the history
  • Loading branch information
domoritz committed Jul 2, 2018
1 parent eab0c42 commit aeec92e
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ install:
- conda install --yes $DEPS
- python setup.py install
- jupyter nbextension install vega --py --sys-prefix
- yarn

before_install:
- wget https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh -O miniconda.sh
Expand All @@ -24,4 +25,5 @@ before_install:
- conda update --yes conda

script:
- yarn lint
- py.test vega
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
},
"homepage": "https://github.com/vega/ipyvega#readme",
"scripts": {
"format": "prettier --write 'src/*.ts'",
"lint": "prettier --list-different 'src/*.ts'",
"build": "webpack --mode production",
"watch": "webpack --mode development --watch"
},
Expand All @@ -21,6 +23,7 @@
},
"devDependencies": {
"css-loader": "^0.28.11",
"prettier": "^1.13.7",
"ts-loader": "^4.4.1",
"typescript": "^2.9.1",
"webpack": "^4.12.0",
Expand Down
2 changes: 1 addition & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import vegaEmbed, { Mode, EmbedOptions } from "vega-embed";
import { Spec } from "vega-lib";
import { TopLevelSpec } from "vega-lite";

export { default as vegaEmbed } from 'vega-embed';
export { default as vegaEmbed } from "vega-embed";

function javascriptIndex(selector: string, outputs) {
// Return the index in the output array of the JS repr of this viz
Expand Down
4 changes: 4 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2469,6 +2469,10 @@ prepend-http@^1.0.0:
version "1.0.4"
resolved "https://registry.yarnpkg.com/prepend-http/-/prepend-http-1.0.4.tgz#d4f4562b0ce3696e41ac52d0e002e57a635dc6dc"

prettier@^1.13.7:
version "1.13.7"
resolved "https://registry.yarnpkg.com/prettier/-/prettier-1.13.7.tgz#850f3b8af784a49a6ea2d2eaa7ed1428a34b7281"

process-nextick-args@~2.0.0:
version "2.0.0"
resolved "https://registry.yarnpkg.com/process-nextick-args/-/process-nextick-args-2.0.0.tgz#a37d732f4271b4ab1ad070d35508e8290788ffaa"
Expand Down

0 comments on commit aeec92e

Please sign in to comment.