New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort #395
Commits on Jul 15, 2016
Commits on Jul 19, 2016
-
Added icon for sorting in data table. May need a new icon since has a…
…uthor's name in the svg icon. Next created component but component has some binding warnings and proptype errors
Commits on Jul 20, 2016
-
still getting error: warning.js:45 Warning: Failed propType: Invalid …
…prop of type supplied to , expected . Check the render method of .
Commits on Jul 22, 2016
-
deleted extra decreasingSort svg and editted with comments the decrea…
…singSort.svg in assets to be styled better in datatable
-
Commits on Jul 27, 2016
-
added new transformReducer. Dispatched custom action that will need t…
…o make action creator in the future
-
-
started working on function in export.js that would take new state an…
…d edit the vega spec with the added transform to sort the values
Commits on Jul 28, 2016
-
added action creator, reducer, and exporter function. However, still …
…need to figure out how to adjust view now
Commits on Jul 29, 2016
-
Added an getSort() function that takes a dataset. This function const…
…ructs the transform part of the vega spec that will be returned in export.dataset(). This function is meant to be used as a helper function for export.dataset(). This is ultimately used to add the sort feature to the DataTable
Commits on Aug 4, 2016
-
Added another action to the vegaReducer invalidating actions to spawn…
… a refresh of the dataset after add transform to the spec. Sort feature seems to be working but will need to test now
-
changed the increasingSort and decreasingSort svg icons. These icons …
…are toggled when click on sort. Found a bug. When click on the icon, only after the hoverField is unhovered the DataTable is updated.
Commits on Aug 5, 2016
-
merged with updated lyra2 branch. Working sort feature just need to e…
…xtra out the changing sort icon into its own component to modularize the code better
Commits on Aug 10, 2016
-
deleted transformReducer that isn't used anymore. Was used when first…
… started working on the sort feature
-
added test to vegaReducer tests to test if store is flagged as invali…
…d when sort action dispatched
Commits on Aug 11, 2016
-
Added some simple tests for datasetReducer. Tests include one that te…
…sts to see if datasetReducer is a function, returns the original state if not an action it accepts, and takes an SORT_DATASET action and updates the store correctly
-
Created test file to test datasetActions action creator method sortDa…
…taset. Tested that all the properties are set in the action returned from sortDataset and the action creator returns an object
-
added header comments to the getSort() function in export.js that cre…
…ates the vega data transform code to be appended to to the spec returned in exporter dataset that will sort the dataset.
Commits on Aug 12, 2016
-
Added a test to test the correct data transform spec is added to the …
…vega spec returned from exporter dataset. This therefore tests the getSort() function added to exporter which is called in exporter dataset.
-
Renamed the tests for exporter dataset. Wrote 2 total new tests which…
… consist of an increasing and decreasing sort. This is to test if the correct data transform vega code is added to the spec returned in exporter dataset
Commits on Aug 16, 2016
-
Deleted increasingSort.svg and decreasingSort.svg and added 4 new ico…
…ns from FontAwesome. Created new component for SortField. Sort feature not completely functional since SortField will sort values but when unhover the values get sorted back to what they were. Also fixed stylistic errors in export.js. Also need to still run npm run lit to test the style
-
Removed store.getState() and moved to mapStateToProps. Also removed I…
…con require in HoverField since moved SortField into its own component
-
-
Fixed more style issues in exporter tests. Fixed isSortAsc to check i…
…f sort.sortOrder property in store is asc or desc instead of checking if sort is asc or desc
-
Changed SortField so that when sort one field the icon changes to a s…
…pecific sort icon but the other rows don't show that they are sorted
-
Refine sort field functionality.
Simplify code paths in the SortField component, move hardcoded strings to constant files, and make stored state more concise.
-
Only re-render DataTable once Vega is done parsing.
Previously, the sort action would trigger a DataTable re-render before Vega was done parsing causing the dataset's *input* values being temporarily used.