Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more flexible @types/react dependency #435

Closed
sgratzl opened this issue Sep 26, 2021 · 1 comment · Fixed by #494
Closed

more flexible @types/react dependency #435

sgratzl opened this issue Sep 26, 2021 · 1 comment · Fixed by #494

Comments

@sgratzl
Copy link

sgratzl commented Sep 26, 2021

"@types/react": "^16.9.19",
"fast-deep-equal": "^3.1.1",
"vega-embed": "^6.5.1"
},
"peerDependencies": {
"react": "^16 || ^17",

states that this react-vega both supports React 16 as well as React 17. However, it depends on @types/react in version 16, which is conflicting with my project using @types/react with version 17.

would be nice if also the dependency on @types/react would support both 16 and 17

sgratzl added a commit to sgratzl/deneb that referenced this issue Sep 26, 2021
@domoritz
Copy link
Member

Sounds like a good idea. Do you want to send a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants