Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @types/react more flexible #479

Closed
wants to merge 1 commit into from
Closed

Conversation

Hazelfire
Copy link

Make the dependency on @types/react similar to the one on react. This is so that users of the library (like myself) can use different versions of @types/react and still trust that it works!

Closes #435

@domoritz
Copy link
Member

domoritz commented Apr 4, 2022

@kristw can you take a look?

@kristw
Copy link
Member

kristw commented Apr 4, 2022

Hmm. The build fail though. May have to regenerate yarn.lock and make sure everything works first.

Copy link
Member

@kristw kristw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix build first

@kristw kristw closed this May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

more flexible @types/react dependency
3 participants