Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending InterfaceAndClassNodeParser #1160

Closed
loopingz opened this issue Mar 16, 2022 · 4 comments · Fixed by #1161
Closed

Extending InterfaceAndClassNodeParser #1160

loopingz opened this issue Mar 16, 2022 · 4 comments · Fixed by #1161
Labels
prerelease

Comments

@loopingz
Copy link
Contributor

When trying to extend the parser InterfaceAndClassNodeParser, I had to duplicate it instead of extending as most methods are private and not protected.

The use case is to define specific override for some specific classes so the schema generator have some preset behavior for my framework classes.

I'm about to send a PR to change this from private to protected, would it make sense to you?
@domoritz
Copy link
Member

That's okay with me as long as all classes are consistent.

@loopingz
Copy link
Contributor Author

Ok I did update all NodeParser and TypeFormatter, I left Type and the classes that were using private and had getter for the private attributes

@loopingz loopingz mentioned this issue Mar 16, 2022
Merged
loopingz added a commit to loopingz/ts-json-schema-generator that referenced this issue Mar 16, 2022
@loopingz
feat: move private to protected to allow extending behavior (Close ve…
583dac4 
…ga#1160)
@github-actions
Copy link

🚀 Issue was released in v0.98.1-next.1 🚀

@github-actions
Copy link

🚀 Issue was released in v0.98.1-next.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prerelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: move private to protected to allow extending behavior loopingz/ts-json-schema-generator
2 participants
@domoritz @loopingz