Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve empty @description #1177

Merged
merged 1 commit into from Mar 22, 2022
Merged

Conversation

Jason3S
Copy link
Contributor

@Jason3S Jason3S commented Mar 22, 2022

Text tags should get an empty string instead of true.

fix: #1176

Version

Published prerelease version: v1.0.1-next.0

Changelog

馃悰 Bug Fix

Authors: 1

Text tags should get an empty string instead of `true`.
@domoritz domoritz merged commit 32e8948 into vega:next Mar 22, 2022
@Jason3S
Copy link
Contributor Author

Jason3S commented Mar 23, 2022

Thank you for landing this. It was a blocker for me.

@github-actions
Copy link

馃殌 PR was released in v1.1.0 馃殌

@github-actions github-actions bot added released This issue/pull request has been released. and removed prerelease labels Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Empty @description becomes "true" instead of being an empty string.
2 participants