fix: incorrect output of Record with numeric key #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baggoedw
force-pushed
the
fix/record-numeric-key
branch
from
1e79317
to
dd38d84
Compare
baggoedw
force-pushed
the
fix/record-numeric-key
branch
from
dd38d84
to
44f3199
Compare
matt-pawley
approved these changes
Jul 5, 2022
This was referenced Sep 21, 2022
Merged
|
🚀 PR was released in |
github-actions
bot
added
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As highlighted in the following issue: #1262
A
Recordwith a numeric key is incorrectly outputted as anarrayinstead of anobject.To fix this, I'm proposing we check the
idof theconstraintType. If that is anumber, then we can safely assume it's anarray. When it is anobject, theidcontains analias.