Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add enum to discriminator to avoid schema accepting too much (#1492) #1493

Merged
merged 4 commits into from
Dec 9, 2022

Conversation

mvanniekerkSQ
Copy link
Contributor

@mvanniekerkSQ mvanniekerkSQ commented Dec 8, 2022

Fixes #1492 and fixes #1494

Since this is the first time I'm looking into the source code of this repository, I'm not sure if I've taken the right approach to solve this. My changes do seem to fix the issue, but there may be some edge cases I have overlooked.

Version

Published prerelease version: v1.2.0-next.4

Changelog

🎉 This release contains work from new contributors! 🎉

Thanks for all your work!

❤️ null@mvanniekerkSQ

❤️ null@swnf

❤️ Thomas (@thomaswr)

❤️ Arthur Fiorette (@arthurfiorette)

❤️ Sean Keenan (@sean9keenan)

🚀 Enhancement

🐛 Bug Fix

🔩 Dependency Updates

Authors: 8

@mvanniekerkSQ
Copy link
Contributor Author

I decided to also fix #1494 in this issue, since the 2 issues are closely related.

@domoritz domoritz enabled auto-merge (squash) December 9, 2022 15:29
@domoritz
Copy link
Member

domoritz commented Dec 9, 2022

Thank you for the pull request!

@domoritz domoritz merged commit 738addd into vega:next Dec 9, 2022
This was referenced Dec 21, 2022
@github-actions
Copy link

🚀 PR was released in v1.2.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prerelease released This issue/pull request has been released.
Projects
None yet
2 participants