Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improved Promise handling to support packages like Prisma #1924
feat: Improved Promise handling to support packages like Prisma #1924
Changes from 22 commits
717bb1a
68b6c0b
09ff47a
19e481f
2d36fbf
2517d66
a13545c
c78f38c
8f80837
624736e
7944bc7
697805f
a05e492
9ca48e0
ec698e2
3b74479
a4a497f
2a3e4ce
42d2bd9
e5daa4a
d6ed5a7
6b11f65
8100f43
e804590
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 38 in src/NodeParser/PromiseNodeParser.ts
Codecov / codecov/patch
src/NodeParser/PromiseNodeParser.ts#L38
Check warning on line 66 in src/NodeParser/PromiseNodeParser.ts
Codecov / codecov/patch
src/NodeParser/PromiseNodeParser.ts#L66
Check warning on line 79 in src/NodeParser/PromiseNodeParser.ts
Codecov / codecov/patch
src/NodeParser/PromiseNodeParser.ts#L79
Check warning on line 90 in src/NodeParser/PromiseNodeParser.ts
Codecov / codecov/patch
src/NodeParser/PromiseNodeParser.ts#L90
Check warning on line 93 in src/NodeParser/PromiseNodeParser.ts
Codecov / codecov/patch
src/NodeParser/PromiseNodeParser.ts#L93
Check warning on line 54 in src/NodeParser/TypeReferenceNodeParser.ts
Codecov / codecov/patch
src/NodeParser/TypeReferenceNodeParser.ts#L54
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this logic into the PromiseNodeParser?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually not, It might be a skill issue of mine but I couldn't get it to work without this statement.
When I remove it, this is the error thrown:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow this type started getting out of order and breaking CI:
https://github.com/vega/ts-json-schema-generator/actions/runs/9105537200/job/25031273060#step:7:25
I changed its order so tests can pass, I'm also almost sure
enum
is order insensitive.