Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support export * statements #1962

Merged
merged 7 commits into from
May 23, 2024
Merged

Conversation

arthurfiorette
Copy link
Collaborator

@arthurfiorette arthurfiorette commented May 22, 2024

Adds support for export * statements.

I could not get export { variable } statements to work with --expose * for now, but I pushed some wip code at arthur/export-braces in case someone wants to continue it.

This PR also refactors some things at SchemaGenerator to improve readability and type safety.

Version

Published prerelease version: v2.2.0-next.1

Changelog

馃帀 This release contains work from new contributors! 馃帀

Thanks for all your work!

鉂わ笍 Sampsa Kaskela (@SampsaKaskela)

鉂わ笍 Rama Krishna Ghanta (@ramaghanta)

鉂わ笍 Tim (@timothympace)

馃殌 Enhancement

馃悰 Bug Fix

馃敥 Dependency Updates

Authors: 6

Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we separate out the refactoring?

jest.config.cjs Outdated Show resolved Hide resolved
@arthurfiorette arthurfiorette self-assigned this May 23, 2024
@arthurfiorette
Copy link
Collaborator Author

done!

@domoritz domoritz changed the title Support for export * statements feat: support export * statements May 23, 2024
@domoritz domoritz merged commit 1b27258 into vega:next May 23, 2024
3 of 4 checks passed
Copy link

馃殌 PR was released in v2.2.0 馃殌

@github-actions github-actions bot added released This issue/pull request has been released. and removed prerelease labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants