Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich tuples support #42

Merged
merged 10 commits into from
Aug 2, 2018
Merged

Rich tuples support #42

merged 10 commits into from
Aug 2, 2018

Conversation

marcoqu
Copy link
Contributor

@marcoqu marcoqu commented Aug 2, 2018

Support for new tuple features introduced in typescript 3.0

export type A = [number, number]
export type A = [number, number, number?]
export type A = [number, number, ...number[]]
export type A = []

This also removes the --strict-tuples option as it is now obsolete.

@domoritz
Copy link
Member

domoritz commented Aug 2, 2018

This is awesome. Thank you so much. I'll review this today.

@domoritz domoritz merged commit 7fa3dbf into vega:master Aug 2, 2018
@domoritz
Copy link
Member

domoritz commented Aug 2, 2018

Works great, thank you!

@domoritz
Copy link
Member

domoritz commented Aug 2, 2018

Thank you so much @marcoqu do the PR. It works great and fixed an issue in Vega-Lite! Since you have contributed in the past as well, I was wondering whether you want to get contributor rights on this repo? You could push branches and close issues and accept PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants