Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should selection be applied to composite marks & mark overlays #3702

Open
kanitw opened this issue May 4, 2018 · 0 comments
Open

How should selection be applied to composite marks & mark overlays #3702

kanitw opened this issue May 4, 2018 · 0 comments
Labels
Area - Interaction P2 Important Issues that should be fixed soon RFC / Discussion 💬 For discussing proposed changes
Milestone

Comments

@kanitw
Copy link
Member

kanitw commented May 4, 2018

Composite marks (pending PR) and mark overlays (e.g., area with line and point overlay) generally produce multiple layers. It's unclear if specified selection should be applied to all layers or only some of them.

It's possible that it's better to apply to only some of them and the rule could depend on selection type.
For example, for line overlayed with points, "single" selection is probably applied to the overlayed points, but not the line (since we can't select individual points in the line). However, for boxplot, it's unclear what's the appropriate behavior esp. that some of the layers are ranged mark and/or aggregated and we don't have selection support for such cases yet.

Note: Since we've not thoroughly determine how to do this for all composite marks yet, our first release of composite marks will totally ignore selections as the behavior is not well defined. While the overlay will not copy/move the selection to the overlay layer. (It is better to not support them yet instead of adding partially broken support and then introduce breaking changes in the future.)

cc: @arvind, @domoritz, @jheer

@kanitw kanitw added this to the 2.x Interaction Patches milestone May 4, 2018
kanitw added a commit that referenced this issue May 4, 2018
kanitw added a commit that referenced this issue May 6, 2018
@kanitw kanitw added the RFC / Discussion 💬 For discussing proposed changes label May 20, 2018
@kanitw kanitw changed the title Apply selection to composite marks & mark overlays How should selection be applied to composite marks & mark overlays May 20, 2018
@kanitw kanitw removed this from the x.x Interaction / Selection milestone Dec 4, 2019
@kanitw kanitw modified the milestones: 5.0, 5.0 - Design TODOs May 15, 2020
@kanitw kanitw added the P2 Important Issues that should be fixed soon label Jun 17, 2020
@kanitw kanitw modified the milestones: 5.0 - Design TODOs, 5.x Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area - Interaction P2 Important Issues that should be fixed soon RFC / Discussion 💬 For discussing proposed changes
Projects
None yet
Development

No branches or pull requests

1 participant