For mark overlays, do not apply selection to the augmented layers yet. #3703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(We will properly do that in #3702)
kanitw
changed the title
|
What problem does this fix? |
|
We don't have a clear policy how to do selection for overlay / composite yet #3702 . This resets the behavior to be "doing nothing". The old code was weird anyway. |
|
Why was the old code weird? I don't think it's good to break selections for overlaid plots. Can you provide some examples where the old code was incorrect or what won't work anymore when we merge this? |
|
The old code remove selection from the area layer and add selection to both point and line overlays. Isn't that weird? |
|
This PR makes the logic for overlay supposes to just add new overlay layers, but preseves selection to be in the original layer. I think this is a reasonable standard logic. We could have more sophisticated policy later. |
domoritz
approved these changes
May 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(We will properly do that later in #3702)