Disable default strokeDash for legend #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,8 +30,7 @@ export function buildModel(spec: Spec, parent: Model, parentGivenName: string): | |||
| } | |||
|
|
|||
| // TODO: figure if we really need opacity in both | |||
| export const STROKE_CONFIG = ['stroke', 'strokeWidth', | |||
| 'strokeDash', 'strokeDashOffset', 'strokeOpacity', 'opacity']; | |||
| export const STROKE_CONFIG = ['stroke', 'strokeWidth', 'strokeOpacity', 'opacity']; | |||
There was a problem hiding this comment.
I don't think this is the right fix. This would make strokeDash unused for both legend and marks.
Why don't you modify the Line 128 in legend.ts like I suggested?
There was a problem hiding this comment.
I did this before I got your suggestion. I will fix it.
|
Fixed it by eliminating the default strokeDash and strokeDashOffset for all marks |
| @@ -146,9 +146,9 @@ export namespace properties { | |||
| applyMarkConfig(symbols, model, | |||
| channel === COLOR ? | |||
| /* For color's legend, do not set fill (when filled) or stroke (when unfilled) property from config because the the legend's `fill` or `stroke` scale should have precedence */ | |||
| without(FILL_STROKE_CONFIG, [ filled ? 'fill' : 'stroke']) : | |||
| without(FILL_STROKE_CONFIG, [ filled ? 'fill' : 'stroke', 'strokeDash', 'strokeDashOffset']) : | |||
There was a problem hiding this comment.
I would organize this chunk of the code a bit so that the comments still make sense.
Ideally I would do something like:
let config = channel === COLOR ?
/* For color's legend, do not set fill (when filled) or stroke (when unfilled) property from config because the the legend's `fill` or `stroke` scale should have precedence */
... :
/* For other legend, no need to omit. */
...;
config = without(config, ['strokeDash', 'strokeDashOffset'])
applyMarkConfig(symbols, model, config)
|
Fixed the style. |
|
Can you add test? (and for future PRs, please add screenshot to help reviewers review PR easier.) |
|
tests and screenshot are added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1314
Now legend won't take
strokeDashandstrokeDashOffsetfrom config for all marks.the following spec create the correct legend symbol now.