-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use faster json schema validator and remove color format. #1717
Conversation
Why remove color format? |
We didn't set it consistently and so I'd rather remove it. Is there a specific use case for it? |
I don't know. I think you added it? |
I added it when we still used it to generate the properties editor in polestar. |
@domoritz oops. Then it's not good to remove it then! |
It's weird that you're suggesting to remove it despite the obvious utility! |
I know we don't have property editor right now, but I can't imagine away to know if a field is color in polestar without this! |
Not reliable but you could assume that stroke, fill, and color are all colors. Anyway, I'm happy to add it again if we need it but since we didn't use it consistently, I removed it. |
Instead of removing it, the right solution is to make it consistent .... |
There are two consistent states: use it nowhere and ensure that whenever we use a color, we specify the format. |
And the "use it nowhere" is not the ideal one... |
No description provided.