Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename marktype to mark #831

Merged
merged 3 commits into from
Dec 4, 2015
Merged

rename marktype to mark #831

merged 3 commits into from
Dec 4, 2015

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Dec 4, 2015

Please merge #830 first!

@kanitw kanitw mentioned this pull request Dec 4, 2015
Closed
@kanitw
Copy link
Member Author

kanitw commented Dec 4, 2015

move instead of delete + create

I thought clicking "rename" in atom would automatically do git mv since it's an editor by github.
That said, is there an easy way to do that. If there is, please help do it and let me know how for next time since I have to leave soon and we should release this morning.
Apologies!

domoritz added a commit that referenced this pull request Dec 4, 2015
@domoritz
Merge pull request #831 from vega/kw/mark
31a3dd8 
rename `marktype` to `mark`
@domoritz domoritz merged commit 31a3dd8 into master Dec 4, 2015
@domoritz domoritz deleted the kw/mark branch December 4, 2015 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@domoritz domoritz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanitw @domoritz