-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vega-Utils in Typescript #1706
Vega-Utils in Typescript #1706
Conversation
fe8655f
to
2438f34
Compare
Do you want me to make any changes @jheer? |
Not at the moment. The main issue for now is that this has the lowest priority on my much-too-long TODO list. Plus, I'm still ultimately unsure if I want to switch to TypeScript and need to do more careful consideration. 🤷♂️ |
After working more with TypeScript over in vega/vega-lite, I've decided not to initiate a port from JS to TS for the core Vega projects. (At least, not in any near-term future.) As a result, I'm closing out this PR as I want to minimize inconsistent languages and styles within this monorepo -- vega-typings being an obvious and necessary exception. Thanks again for your efforts here. We could have a separate conversation about whether or not it makes sense for vega-util to leave the monorepo as a stand-alone project (I'm skeptical, but it's a possibility), in which case a TypeScript conversion might be more fitting. |
New version of #1566
Please squash when merging.