Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vega-Utils in Typescript #1706

Closed
wants to merge 11 commits into from
Closed

Vega-Utils in Typescript #1706

wants to merge 11 commits into from

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented Mar 16, 2019

New version of #1566

Please squash when merging.

@domoritz domoritz marked this pull request as ready for review March 16, 2019 18:21
@domoritz domoritz requested a review from jheer March 16, 2019 19:07
@jheer jheer force-pushed the master branch 2 times, most recently from fe8655f to 2438f34 Compare March 25, 2019 05:41
@domoritz
Copy link
Member Author

Do you want me to make any changes @jheer?

@jheer
Copy link
Member

jheer commented Mar 29, 2019

Not at the moment. The main issue for now is that this has the lowest priority on my much-too-long TODO list. Plus, I'm still ultimately unsure if I want to switch to TypeScript and need to do more careful consideration. 🤷‍♂️

@jheer
Copy link
Member

jheer commented Apr 6, 2019

After working more with TypeScript over in vega/vega-lite, I've decided not to initiate a port from JS to TS for the core Vega projects. (At least, not in any near-term future.) As a result, I'm closing out this PR as I want to minimize inconsistent languages and styles within this monorepo -- vega-typings being an obvious and necessary exception.

Thanks again for your efforts here. We could have a separate conversation about whether or not it makes sense for vega-util to leave the monorepo as a stand-alone project (I'm skeptical, but it's a possibility), in which case a TypeScript conversion might be more fitting.

@jheer jheer closed this Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants