Update formatting, add locale support. #313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all axis, legend and template formatting to pass through datalib's formatting support (^1.4.2). As a result Vega/Datalib now control all automatic formatting decisions, with no reliance on (inconsistent) D3 scale
tickFormat
methods. Most importantly, these facilities support runtime changes to current number and time locale formatting.For example, to change the number formatting to German (DE-DE):
To change the time formatting to German (DE-DE):
For more about locale settings, see the d3-format and d3-time-format module repositories.