fix: Make __count__ private from schema
#3659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The types should be in sync with the schema imo. |
|
Please remove the compiled Vega files. We make those updates in a release. |
lsh
force-pushed
the
lsh/schema-pivot-fix
branch
from
b1a5fe1
to
b3beabf
Compare
lsh
force-pushed
the
lsh/schema-pivot-fix
branch
from
099d296
to
30af17d
Compare
domoritz
changed the title
__count__ private from schema__count__ private from schema
domoritz
approved these changes
Feb 10, 2023
|
Thank you. Looks good to me. @jheer can you merge this? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
__count__appears in the aggregate ops in the schema. This should be hidden for internal use inPivotoperations (confirmed by @jheer over Slack).