Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update to the zoomable circle packing example #3857

Merged
merged 2 commits into from
Jan 9, 2024
Merged

docs: update to the zoomable circle packing example #3857

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d93d9d7
docs: update to the zoomable circle packing example: removed trailing…
Giammaria Jan 7, 2024
e65d5a2
Update docs/examples/zoomable-circle-packing.md
domoritz Jan 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/examples/zoomable-circle-packing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ spec: zoomable-circle-packing
image: /examples/img/zoomable-circle-packing.png
---

This is an extension of the [Circle Packing Example](../circle-packing). This version was implemented by [@giammaria](https://github.com/Giammaria). It incorporates a timer to facilitate zoom and fade animations, offering a technique beneficial for drill-down behavior and exploration. For simplicity, the example reveals only a few text marks upon zoom, corresponding to the user-selected node. Alternatively, you can render various mark types, axes, legends, etc., to provide additional insights into the selected node."
This is an extension of the [Circle Packing Example](../circle-packing). This version was implemented by [@giammaria](https://github.com/Giammaria). It incorporates a timer to facilitate zoom and fade animations, offering a technique beneficial for drill-down behavior and exploration. For simplicity, the example reveals only a few text marks upon zoom, corresponding to the user-selected node. Alternatively, you can render various mark types, axes, legends, etc., to provide additional insights into the selected node. Click [here](https://vega.github.io/editor/#/gist/566dc5abf4ba78d4187b1788c96136ac/spec.json) to see a more involved example in the editor.
domoritz marked this conversation as resolved.
Show resolved Hide resolved

{% include example spec=page.spec %}
4 changes: 2 additions & 2 deletions docs/examples/zoomable-circle-packing.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"$schema": "https://vega.github.io/schema/vega/v5.json",
"description": "An example of a zoomable circle packing layout for hierarchical data.",
"width": 800,
"height": 800,
"width": 600,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to rebuild the image?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I follow. I'm assuming that you're not referring to the thumbnail image, correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Contributor Author

@Giammaria Giammaria Jan 7, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the only spec update being the width and height (same aspect ratio), the existing thumbnail looks good in my dev environment and should do the trick. I'm happy to update it though if you think that I should. Just let me know 👍

"height": 600,
"padding": 5,
"signals": [
{
Expand Down