docs: update to the zoomable circle packing example #3857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… double quote (") from description; added a hyperlink to a more complex example; adjusted width and height of example to match the regular circle packing example
domoritz
approved these changes
Jan 7, 2024
domoritz
approved these changes
Jan 7, 2024
| @@ -1,8 +1,8 @@ | |||
| { | |||
| "$schema": "https://vega.github.io/schema/vega/v5.json", | |||
| "description": "An example of a zoomable circle packing layout for hierarchical data.", | |||
| "width": 800, | |||
| "height": 800, | |||
| "width": 600, | |||
There was a problem hiding this comment.
Do we need to rebuild the image?
There was a problem hiding this comment.
Not sure I follow. I'm assuming that you're not referring to the thumbnail image, correct?
There was a problem hiding this comment.
With the only spec update being the width and height (same aspect ratio), the existing thumbnail looks good in my dev environment and should do the trick. I'm happy to update it though if you think that I should. Just let me know 👍
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed trailing double quote (") from description; added a hyperlink to a more complex example; adjusted width and height of example to match the regular circle packing example
Note - accidentally overwrote the commits in my local repository for #3856. That PR has been closed. This PR is intended to replace that one.
INFO: @domoritz