Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing aggregate_params to window transform type #3874

Merged
merged 1 commit into from Feb 18, 2024
Merged

fix: add missing aggregate_params to window transform type #3874

merged 1 commit into from Feb 18, 2024

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented Feb 13, 2024 •
edited

aggregate_params can also be used in window transforms, but the type WindowTransform is not updated.

Related to vega/vega-lite#9225 (comment), followup to #3686

@julieg18 julieg18 marked this pull request as ready for review February 13, 2024 15:53
@julieg18 julieg18 requested a review from a team as a code owner February 13, 2024 15:53
@julieg18 julieg18 mentioned this pull request Feb 13, 2024
Open
5 tasks
domoritz
domoritz approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@domoritz domoritz merged commit 697ae0c into vega:main Feb 18, 2024
5 checks passed
@lsh lsh mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz domoritz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julieg18 @domoritz