fix: Respect tickMinStep for binned scale #3904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
approved these changes
Apr 19, 2024
|
LGTM. I'll defer to @lsh to merge and release. |
Merged
lsh
added a commit
that referenced
this pull request
May 10, 2024
**docs** * remove Google Analytics. (via #3894) (Thanks @domoritz!) **monorepo** * switch to ESLint flat config file. (via #3920) (Thanks @lsh!) * update node versions in ci. (via #3915) (Thanks @domoritz!) **vega-encode** * use domainMin and domainMax to set scale padding. (via #3906) (Thanks @Jami159 & @lsh!) **vega-scale** * Add observable10 palette. (via #3843) (Thanks @mcnuttandrew!) * Respect tickMinStep for binned scale. (via #3904) (Thanks @alexxu-db!) **vega-scenegraph** * Revert TooltipHideEvent to MouseOutEvent to fix events on mobile. (via #3909) (Thanks @kadamwhite!) **vega-typings** * Add observable10 palette. (via #3843) (Thanks @mcnuttandrew!) **vega-view** * turn off all handlers in View.finalize() to fix memory leak. (via #3896) (Thanks @cmerrick!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we do not pass in the
count(calculated based ontickMinStep) while generating tick values for binned scale.This causes performance issues especially when there exist a huge amount of bins. Attempting to render too many ticks will sometimes even crash the browser tab.
Before:
After:
(
tickMinStepboth set to0.1)