-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linestack with italic lables #195
Comments
It seems that other expressions may fail as well. With Obviously we do not handle expressions gracefully (at least not in macOS with current R release). This should be fixed. It seems that |
It seems that instead of putting This commit was released in vegan-2.3-4 and the example with This is a regression that must be fixed. |
If have currently
but this might be not a good idea because
A possible better fix would be to coerce to character only for strheight, that is: |
As for why the
I would suggest we just go with whatever I'll take a look as the original contributor of the expression code in |
Vector
I'm inclined to not fix the Thoughts? |
Or; it would make more sense to add
I've fixed the expression issue. I'll implement the proposal here [in branch issue-#195 *] ( |
issue-#195 branch seems to fix the bug that I introduced. That should be merged. You have |
Thanks @gavinsimpson! I just came up with |
@gavinsimpson , would issue-#195 branch be OK for the 2.4-1 release? What ever we do with the I have now made all Fortran fixes -- including the error-prone |
bug fix part was merged to cran-2.4 branch and the milestone was removed. Feature-request part is still valid. |
I think the feature-request part can be closed, as there is a practical solution? |
Yes indeed, the issue-#195 branch was merged to master long ago. |
Why?
For species names in
linestack()
it sometimes might be desirable to plot them in italics.To plot all labels in italics we can use
Problem
But this does not work if we mix italics and non-italics:
A possible solution would be a
expression
:But this parses wrongly, because
labels=
are converted internally to characters.Possible Fix
A quick fix would be to remove the coercion to character or add an exception for expressions (Lines 13 -14 of
linestack.R
.labels
are downstream only used once instrheight()
and I think in most cases the expression has the same height as the labels (?!).May be there are also other options?
The text was updated successfully, but these errors were encountered: