-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRAN Warning #322
Comments
labdsv ditches rndtaxa and adds new funciton rndcomm which is not completely identical, but provides similar alternative as some of vegan quantitative null model. However, x-ref would be version dependent, and I completely remove the reference to labdsv function at the moment. This is a tiny issue, but still triggered a warning in CRAN, and I got a message: Please see the problems shown on <https://cran.r-project.org/web/checks/check_results_vegan.html>. Please correct before 2019-08-19 to safely retain your package on CRAN. Issue #322 in GitHub.
labdsv ditches rndtaxa and adds new funciton rndcomm which is not completely identical, but provides similar alternative as some of vegan quantitative null model. However, x-ref would be version dependent, and I completely remove the reference to labdsv function at the moment. This is a tiny issue, but still triggered a warning in CRAN, and I got a message: Please see the problems shown on <https://cran.r-project.org/web/checks/check_results_vegan.html>. Please correct before 2019-08-19 to safely retain your package on CRAN. Issue #322 in GitHub. (cherry picked from commit 16bbf90)
I'll work on #300 I heard tell that the submission queue was going to be closed until later in August. If true, we might want to clarify those closure dates and then decide whether to get this done ASAP and in before the close or wait until it reopens, but if that is post the 18th we might want to let CRAN know our intentions. |
The CRAN issue is really insignificant and I already fixed that. In addition, there are a couple of bug fixes and one clean-up of user interface, and I could pack up vegan_2.5-6 very soon. NEWS of the changes is the only piece that is needed. I also noticed that CRAN incoming queue will closed on Friday August 8, but I could quite well submit the package by Thursday if we don't want more time for any other reason. |
The release is forced because CRAN alerted about missing documentation link after labdsv removed function rndtaxa. This change is so insignificant that we do not list it in these NEWS. See issue #322 in github.
@gavinsimpson : I added NEWS about changes. vegan_2.5-6 would be ready for CRAN as it stands now. The only question is, do we want it be something more than it stands now. |
@jarioksa the PR in #300 would be easy to merge but the bigger issue is adding the same functionality or ideas for some other related functions as you mention in #300. I won't have time before the 8th to deal with the larger issue, so if you want to push this fix to CRAN to avoid issues, I'm cool with that. I'll be able to work on the bigger set of functions at the weekend. |
@gavinsimpson I uploaded 2.5-6 to CRAN. It includes the CRAN fix, two bug fixes and one tidying of printed results. The #300 should be fixed some day, but it is not really crucial for this release. The CRAN incoming queue closes "tomorrow" (I assume UTC+2). Let's see if they can have this before that deadline. I won't tag this version before it's accepted. |
Submission was rejected: http://www.worldagroforestry.org/resources/databases/tree-diversity-analysis gave 404 in |
I got a new message with a new deadline of 2019-09-03 (in the weird date format used in R). I have fixed the problem of the previous submission and added one new bug fix (Hill scaling is open-ended at top). I am preparing for a submission on Friday, August 30 (UTC+3) if there are no objections. |
I tried again today, and submitted vegan after further editing. All changes are janitorial and mainly concern web addresses. These sunk the last submission, and new cases appeared in Win-Builder checks. It seems that CRAN is getting increasingly picky against insecure ( |
Release 2.5-6 was accepted today. Unfortunately this breaks dispRity: fixing issue |
I got the following message from CRAN:
The issue itself is really insignificant:
However, this opens up a window for other fixes (such as PR #300 for @gavinsimpson )
The text was updated successfully, but these errors were encountered: