Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using expression() for labels #374

Open
ManuelPopp opened this issue Jul 20, 2020 · 2 comments
Open

Using expression() for labels #374

ManuelPopp opened this issue Jul 20, 2020 · 2 comments
Labels
feature-request

Comments

@ManuelPopp
Copy link

ManuelPopp commented Jul 20, 2020 •
edited
Loading

Could you make it possible to successfully pass a vector including expression() to the "label = "-option when adding text(), e.g. to a RDA or db-RDA plot?
When I have a db-RDA with minimum temperature as an explaining variable, it would be great to label the respective arrow with "T" and a small "min", which seems to be currently not possible from within the text() call that produces the arrows and labels.
jarioksa added a commit that referenced this issue Aug 8, 2020
@jarioksa
allow expressions in text.cca labels (per wish of issue #374)
5cb1aa6 
Not tested in all cases (e.g., what would happen with select?).
Should also see other plotting functions for this option, most
importantly with envfit().
jarioksa added a commit that referenced this issue Aug 11, 2020
@jarioksa
more robust implementation of handling labels in text.cca
1273058 
should now implement allowing expression in labels per wish
of github issue #374
@jarioksa
Copy link
Contributor

Implementing this wish was a bit more complicated than I anticipated. However, now it seems to be done. This is now in a dedicated branch https://github.com/vegandevs/vegan/tree/expression-labels which is not yet merged. I'll try the new code with different scenarios, and if everything looks OK, I'll merge it ASAP.

@ManuelPopp
Copy link
Author

That's good to hear. I think it always looks better when labels are not restricted to plain text; Thank you very much, I'm looking forward to the release 👍

jarioksa added a commit that referenced this issue Aug 12, 2020
@jarioksa
Merge branch 'expression-labels'
5ec2124 
Redesigned use of labels in text.cca. This involved adding new function
labels.cca. Now it is possible to use expression() as a label per
wish of github issue #374.
jarioksa added a commit that referenced this issue Nov 11, 2020
@jarioksa
allow expressions in text.cca labels (per wish of issue #374)
b8e5fed 
Not tested in all cases (e.g., what would happen with select?).
Should also see other plotting functions for this option, most
importantly with envfit().

(cherry picked from commit 5cb1aa6)
jarioksa added a commit that referenced this issue Nov 11, 2020
@jarioksa
more robust implementation of handling labels in text.cca
c8e5771 
should now implement allowing expression in labels per wish
of github issue #374

(cherry picked from commit 1273058)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jarioksa @ManuelPopp