Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EstimatePosition API returns incorrect margin estimate with perps edge case #10121

Closed
witgaw opened this issue Nov 16, 2023 · 0 comments · Fixed by #10119, #10122 or #10124
Closed

EstimatePosition API returns incorrect margin estimate with perps edge case #10121

witgaw opened this issue Nov 16, 2023 · 0 comments · Fixed by #10119, #10122 or #10124
Assignees
@witgaw
Labels
bug mainnet-issue
Milestone
🏰 Palazzo Mistero

Comments

@witgaw
Copy link
Member

witgaw commented Nov 16, 2023

When market doesn't have at least 1 of each price observations (internal and external) the funding payment doesn't get exchanged, but Margin Estimate assumes it will happen and hence provides and incorrect estimate for side due to make the payment.
@witgaw witgaw added the bug label Nov 16, 2023
@witgaw witgaw self-assigned this Nov 16, 2023
@witgaw witgaw mentioned this issue Nov 16, 2023
Merged
@witgaw witgaw linked a pull request Nov 16, 2023 that will close this issue
Perps: use same check for theoretical and actual funding payment #10119
Merged
@witgaw witgaw mentioned this issue Nov 16, 2023
Merged
@gordsport gordsport added this to the 🏰 Palazzo Mistero milestone Nov 17, 2023
@vega-issues vega-issues reopened this Nov 17, 2023
@wwestgarth wwestgarth mentioned this issue Nov 17, 2023
Merged
@wwestgarth wwestgarth linked a pull request Nov 17, 2023 that will close this issue
fix: estimate position API does not need to scale funding payment sin… #10124
Merged
@vega-issues vega-issues reopened this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@witgaw witgaw

Labels
bug mainnet-issue
Projects
Core Kanban
Archived in project
Known Issues Board
Status: Deployed to Mainnet
Milestone
🏰 Palazzo Mistero
3 participants
@witgaw @gordsport @vega-issues