Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: estimate position API does not need to scale funding payment sin… #10124

Merged
merged 1 commit into from Nov 17, 2023

Conversation

wwestgarth
Copy link
Contributor

@wwestgarth wwestgarth commented Nov 17, 2023

relates to #10121

Funding payment is already in asset-price so scaling it in EstimatePosition is not necessary.

@wwestgarth wwestgarth requested a review from a team as a code owner November 17, 2023 12:34
@wwestgarth wwestgarth self-assigned this Nov 17, 2023
@EVODelavega EVODelavega merged commit 0eb157d into develop Nov 17, 2023
16 checks passed
@EVODelavega EVODelavega deleted the fix-margin-estimate-scaling branch November 17, 2023 14:00
jeremyletang pushed a commit that referenced this pull request Nov 17, 2023
fix: estimate position API does not need to scale funding payment sin…
@gordsport gordsport added the bug label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EstimatePosition API returns incorrect margin estimate with perps edge case
4 participants