-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/2070 faucet requests limits #2075
Conversation
system-tests failed.
|
04989b5
to
c508cec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks alright to me, but needs someone better at Go. I like the rate limit and agree with a comment in Slack that you made that in a followup we need to limit the amounts that people can request.
The reason for that is https://github.com/orgs/vegaprotocol/projects/44 - someone could right now one day request 10000000000 BTC and without auction mode we're see another crash out. Which is totally possible now with the old notifyTrader approach, hence saying it's alright for a followup ticket.
system-tests failed.
|
1 similar comment
system-tests failed.
|
system-tests failed.
|
system-tests failed.
|
562396b
to
86ce579
Compare
add requests number limit to the faucet.
user are grey listed when they do a request to the faucet for a given asset for the duration of the cool down setted up in config.
close #2075