-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the maxAmount to be mint by the faucet in the definition of the builtin asset #2078
Conversation
Related: #2075 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nonblocking: I've noticed many min/max functions floating around in different blocks of code. Does it make sense to put them in all one place (a maths or utils library maybe) ?
It could make sense indeed. If I'm opening a ticket now so we can audit this later on, is that fine by you @peterbarrow ? |
system-tests failed.
|
system-tests failed.
|
…n request funds from the faucet
system-tests failed.
|
system-tests failed.
|
This adds a new fields in the builtins assets so we can define what's the max amount which can be requested through the faucet.