Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light clean up based on goland report #3085

Merged
merged 11 commits into from
Mar 4, 2021
Merged

Light clean up based on goland report #3085

merged 11 commits into from
Mar 4, 2021

Conversation

ValentinTrinque
Copy link
Contributor

Close #2979

@ValentinTrinque ValentinTrinque force-pushed the feature/2979-clean-up-goland-report branch from f58a4f0 to 65a1dae Compare March 4, 2021 09:07
jeremyletang
jeremyletang approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@jeremyletang jeremyletang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acceptable...

@ValentinTrinque ValentinTrinque merged commit cf5805f into develop Mar 4, 2021
@ValentinTrinque ValentinTrinque deleted the feature/2979-clean-up-goland-report branch March 4, 2021 09:40
@edd edd mentioned this pull request Mar 16, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyletang jeremyletang jeremyletang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review code cleanup report from Goland
2 participants
@ValentinTrinque @jeremyletang