Remove Party from OrderAmendment #3443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinTrinque
force-pushed
the
feature/3440-remove-party-id-from-order-amendment
branch
from
97f73bc
to
799a4ed
Compare
jeremyletang
force-pushed
the
feature/3440-remove-party-id-from-order-amendment
branch
from
799a4ed
to
7f6487a
Compare
jeremyletang
approved these changes
May 5, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the party id form the OrderAmendment.
Blocked since it needs prior refactor of the liquidity engine to return a collection of Order to cancel instead of returning a collection of OrderAmendment.
Closes #3440