New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove party_id from OrderAmendment command #3440

Closed

jeremyletang opened this issue Apr 30, 2021 · 0 comments · Fixed by #3443

Assignees

Labels

Member

jeremyletang commented Apr 30, 2021

Our proto message for OrderAmendment command contain a party_id.

This field should be remove as it should not be possible to amend an order for another party.
The party can be retrieved from the transaction.

jeremyletang assigned ValentinTrinque

ValentinTrinque added tech-debt api labels

ValentinTrinque mentioned this issue

Remove Party from OrderAmendment #3443

Merged

ValentinTrinque added the blocked_by_dependency label

jeremyletang closed this as completed in #3443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment