Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor spec/Spec.scala #137

Merged
merged 2 commits into from Jul 10, 2018
Merged

Conversation

oshikiri
Copy link
Collaborator

@oshikiri oshikiri commented Mar 23, 2018

@codecov-io
Copy link

codecov-io commented Mar 23, 2018

Codecov Report

Merging #137 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #137    +/-   ##
======================================
  Coverage       0%     0%            
======================================
  Files          27     27            
  Lines        1783   1906   +123     
  Branches        5      5            
======================================
- Misses       1783   1906   +123
Impacted Files Coverage Δ
core/src/main/scala/vegas/spec/Spec.scala 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1941b6...efef072. Read the comment docs.

Copy link
Collaborator

@rgbkrk rgbkrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a pretty clean refactor

@oshikiri
Copy link
Collaborator Author

@rgbkrk Thanks!

@oshikiri oshikiri merged commit 9c591c2 into vegas-viz:master Jul 10, 2018
@oshikiri oshikiri deleted the refactor-spec-scala branch July 10, 2018 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants