Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Refactor spec/Spec.scala" #147

Merged
merged 1 commit into from Aug 13, 2018
Merged

Conversation

oshikiri
Copy link
Collaborator

@oshikiri oshikiri commented Jul 24, 2018

Reverts #137

I have noticed that Spec.scala was generated automatically.
I will add an warning message (ex. Do NOT edit this file manually) in another PR.

val dest = file("core/src/main/scala/vegas/spec/Spec.scala")

https://github.com/vegas-viz/Vegas/blob/1496432875f80e9e579cc584fa8fd299f34a71a6/CONTRIB.md#dev-and-debugging-tips

@codecov-io
Copy link

codecov-io commented Jul 24, 2018

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #147    +/-   ##
======================================
  Coverage       0%     0%            
======================================
  Files          27     27            
  Lines        1906   1783   -123     
  Branches        5      5            
======================================
+ Misses       1906   1783   -123
Impacted Files Coverage Δ
core/src/main/scala/vegas/spec/Spec.scala 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1496432...dc4081c. Read the comment docs.

@oshikiri oshikiri requested a review from rgbkrk July 31, 2018 14:53
@oshikiri oshikiri mentioned this pull request Aug 13, 2018
@oshikiri oshikiri merged commit f9393a1 into master Aug 13, 2018
@oshikiri oshikiri deleted the revert-137-refactor-spec-scala branch August 13, 2018 15:07
@oshikiri oshikiri mentioned this pull request Aug 17, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants