Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Document the helper scripts #440

Merged

Conversation

BenjamenMeyer
Copy link
Member

Add some documentation about the helper scripts

Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.

Please answer the following:

Code Changes:

Issues:

Purpose:
Document the helper scripts that @evertvorster created.

Add some documentation about the helper scripts
@stephengtuggy
Copy link
Contributor

So I'm not actually sure that the vsettings script or icon has made it into the assets beta yet. I think they may have been committed on master only. Let's make sure that that is rectified, otherwise we will be documenting a script that doesn't exist.

Copy link
Contributor

@stephengtuggy stephengtuggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change to request. Otherwise, looks good.

README.md Outdated Show resolved Hide resolved
@BenjamenMeyer
Copy link
Member Author

I checked the 0.7.x Beta 3 Deb file and can confirm the scripts are in there.

Copy link
Contributor

@stephengtuggy stephengtuggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@stephengtuggy stephengtuggy merged commit 9d06eb5 into vegastrike:0.7.x Apr 7, 2021
@BenjamenMeyer BenjamenMeyer moved this from In progress to Done in 0.7.x Release Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
0.7.x Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants