Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

posh.h add Aarch64 support #448

Merged
merged 1 commit into from
May 13, 2021
Merged

posh.h add Aarch64 support #448

merged 1 commit into from
May 13, 2021

Conversation

susnux
Copy link
Contributor

@susnux susnux commented May 8, 2021

This is a patch from the openSUSE games repository to enable Aarch64 support.

Copy link
Member

@BenjamenMeyer BenjamenMeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any options that need to be added to the CMakeLists.txt as well?
See https://github.com/vegastrike/Vega-Strike-Engine-Source/blob/master/engine/CMakeLists.txt#L558 for custom options set for the various architectures (note: it is out of date in that many newer architectures are not present).

@susnux
Copy link
Contributor Author

susnux commented May 11, 2021

Are there any options that need to be added to the CMakeLists.txt as well?

Need? No. Could? Yes.
But as with x86 there are so many different configurations outside, even x86 options are not complete or up-to-date.
E.g. you could add armv7 NEON extension, or NEON2, or ARMv8-A Advanced SIMD...

But if you think this is options are useful and relevant, I can have a look into this.

@BenjamenMeyer
Copy link
Member

@susnux I'm not sure...the compilers generally do more of that now; personally I'm not positive we even need the ones that were specified originally; just wanted to verify that something more isn't required to match it all up

@Loki1950 Loki1950 self-assigned this May 13, 2021
@Loki1950 Loki1950 self-requested a review May 13, 2021 15:47
@Loki1950 Loki1950 removed their assignment May 13, 2021
@Loki1950 Loki1950 merged commit dcfcf72 into vegastrike:master May 13, 2021
@BenjamenMeyer
Copy link
Member

Do note that while this will help with AARCH64 systems they're not presently on our targetted list of supported system. I guess we'll need to add it for M1 Mac Support; but we'll also need a CI environment for it too.

stephengtuggy pushed a commit to stephengtuggy/Vega-Strike-Engine-Source that referenced this pull request May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants