engine/src/cmd/movable.cpp: Apply ermo's suggested patch for arithmetic exception during PWCU game load

[stephengtuggy]

Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.

Please answer the following:

Code Changes:

• Have the PR Validation Tests been run? See https://github.com/vegastrike/Vega-Strike-Engine-Source/wiki/Pull-Request-Validation
• This is a documentation change only

Issues:

• Please list any related issues
• Closes PWCU + Vega Strike (Py3) #474

Purpose:

• What is this pull request trying to do? Port engine/src/cmd/movable.cpp: Apply ermo's suggested patch for arithmetic exception during PWCU game load #509 to master
• What release is this for? 0.9.x
• Is there a project or milestone we should apply this to? 0.9.x

[stephengtuggy]

Finished play testing with VS:UtCS data set, on Windows. Note that I'm getting a segfault on exit, specifically when running Vega Strike from within the Visual Studio Code debugger. I will need to do some more investigation to make sure that this PR didn't introduce that problem.

[stephengtuggy]

Also tried testing with the PWCU data set on Windows, but it crashed on startup with an XML parse error. It sounds like PWCU wasn't working on Windows anyway, though, so not sure if this is a new issue either.

[ministerofinformation]

Finished play testing with VS:UtCS data set, on Windows. Note that I'm getting a segfault on exit, specifically when running Vega Strike from within the Visual Studio Code debugger. I will need to do some more investigation to make sure that this PR didn't introduce that problem.

No - that's been there for a while. I forgot to file an issue for it, since it was only on-exit.

[stephengtuggy]

Finished play testing with VS:UtCS data set, on Windows. Note that I'm getting a segfault on exit, specifically when running Vega Strike from within the Visual Studio Code debugger. I will need to do some more investigation to make sure that this PR didn't introduce that problem.

No - that's been there for a while. I forgot to file an issue for it, since it was only on-exit.

@ministerofinformation OK. Yes, I just tried running the code on master, and I had the same issue. So it wasn't introduced by this PR.

[stephengtuggy]

And the code in this PR works fine with PWCU on Linux. So this is good to go. Merging.